Open
Conversation
Member
|
Thanks Josh, |
Author
|
Any decent DVCS should be able to handle this, since each spelling fix is a single commit, basically you just let the rebase drop each conflicting commit and then for the conflicts you look at what they were trying to do. OTOH, because of the way the commits are structured, applying the changes manually may be just as easy, which is fine w/ me. I don't mind. And when the application is ready, just ping me, I'm happy to give it a spin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yes, one or two of these changes may be to third party libraries, please feel free to submit those changes to them....
Using consistent and expected spelling in code, comments and documentation especially for Samples such as this helps everyone.